feat: Set sampledToLocalTracing flag to true for all gRPC MethodDescriptors #3874
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
product-auto-label
bot
added
size: l
lqiu96
changed the title
|
Looks like sonatype is complaining about inadequate coverage for the generated showcase files. This should be a non-issue. |
lqiu96
changed the title
lqiu96
changed the title
blakeli0
reviewed
Aug 14, 2025
blakeli0
reviewed
Aug 14, 2025
|
|
blakeli0
approved these changes
Aug 15, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See b/416626151 for more information.
Problem: When the sampledToLocalTracing is set to false or not set, the gRPC specific metrics have the
grpc.methodattribute defined asotherinstead of the methodDescriptor's full name. This may be confusing to customers who may expect to see the full gRPC method name.High Level: This flag enables captures for specific method names to help provide more detailed metrics. We do not expect any noticeable performance impact from this change.
This does not impact the method name that is already properly captured for Gax Metrics (e.g. Attempt Count, Operation Latency, etc). Specifically, the use must be using grpc-java telemetry module and be using GrpcOpenTelemetry instead of OpenTelemetry.